decker-edu / decker

A markdown based tool for slide deck creation.
GNU General Public License v3.0
60 stars 15 forks source link

Avoid password save prompts for question tokens #70

Closed kno10 closed 11 months ago

kno10 commented 11 months ago

I use incognito mode a lot, in particular for testing.

When switching slides I frequently get displayed the prompt to save/update the password in firefox, which is annoying.

Maybe the password field could be filled only on first use? Alternatively, if the field is named "token" and not "password" then it will likely not be saved, but I guess it is intentional to save it.

monofon commented 11 months ago

Assuming the admin password field on the feedback panel is the problem here, that behaviour is indeed intentional.

Out of curiosity, why do you use incognito mode for testing?

kno10 commented 11 months ago

Not the user+password login field in the bottom, but the pre-filled "user token" at the top for the question functionality. I open sites in incognito mode by default to frequently reset cookies. Also, this is very useful for simulating first visits and judging cross-browser behaviour.

monofon commented 11 months ago

I see. The token mechanism is actually overkill as it is. I'll look into removing that entirely.

monofon commented 11 months ago

@salbeira since you rewrote this whole thing, you get to remove the token field 😁 .

salbeira commented 11 months ago

Feature was merged.