search

decker-edu / decker

A markdown based tool for slide deck creation.
GNU General Public License v3.0
53 stars 13 forks source link

add quotes around every part of commands inside makefile #75

Closed salbeira closed 8 months ago

salbeira commented 8 months ago

Having a space in a directory name on the file path to the stack build directory causes the cp command (and probably others inside our makefile) to fail due to the command being exanded becoming something like:

cp /path/to/My Projects/decker/.stack-work/bin/decker "/home/user/.local/bin/decker"

As you can see ... that cp tries to copy /path/to/My and Projects/decker.stack-work/... to /home/user/.local/bin/decker which is not a directory. (<- the last part of this sentence is quoted from the error message that appears 😄 )

monofon commented 8 months ago

LGTM

salbeira commented 8 months ago

Seems like it has not been merged?