decoderleco
commented
3 years ago Thx, I merged things that would not impact results. I tried to start my PC with a brand new windows today but it crashes all the time. I'll try to repair it tomorrow. If it doesn't work, I'll have to change. So I'm not able to run the whole process because I can't install Rstudio on my professional computer. Do you know if I can run this online?
Le mar. 22 juin 2021 à 20:49, JeanGarf @.***> a écrit :
Hi P.,
The changes on lines 114 and 120 are the biggest issues I've found right now in your work.
Before this commit, numbers like 32.256,45 (found in the middle of the downloaded data file) where converted as 32.256.45 and therefore may be mis-interpreted, which may potentially have a huge impact on your results.
Because of the other issues, I was not able to run the whole process. Therefore, could you check if this correction has an impact or not on your results and conclusions ?
Thanks a lot for all your work.
Best regards,
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/decoderleco/deces_europe/pull/11#issuecomment-866244405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUBA4XAJWAAR6HYSRDJNDT3TUDLJ7ANCNFSM467MHRXA .
Hi P.,
The changes on lines 114 and 120 are the biggest issues I've found right now in your work.
Before this commit, numbers like 32.256,45 (found in the middle of the downloaded data file) where converted as 32.256.45 and therefore may be mis-interpreted, which may potentially have a huge impact on your results.
Because of the other issues, I was not able to run the whole process. Therefore, could you check if this correction has an impact or not on your results and conclusions ?
Thanks a lot for all your work.
Best regards,