Closed sayakpaul closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
There are three things to comment:
Since we are going to inject which model to use from 🤗 Model Hub
, we need to reference a model hosted in 🤗 Model Hub
. I have prepared a test repository just now: https://huggingface.co/chansung/test-unet/tree/main.
from_pretrained_keras
API from huggingface_hug
package.In order to generalize a bit, I think it could be better to make labels.txt
file while removing def sidewalk_palette()
from the code.
It would be nice to include a couple of default images to run inference
WDYT?
In order to generalize a bit, I think it could be better to make labels.txt file while removing def sidewalk_palette() from the code.
Sure we can do that when writing code for the Hugging Face space. For a notebook that benefits from interactive usage, I think it would introduce unnecessary back and forth.
I will address rest of the comments tomorrow.
@deep-diver up for another review.
LGTM! Thanks for the great work :)
Closes #16.