search

deep-diver / semantic-segmentation-ml-pipeline

Machine Learning Pipeline for Semantic Segmentation with TensorFlow Extended (TFX) and various GCP products
https://blog.tensorflow.org/2023/01/end-to-end-pipeline-for-segmentation-tfx-google-cloud-hugging-face.html
Apache License 2.0
93 stars 20 forks source link

update to reflect dataset changes (to PETS) #48

Closed deep-diver closed 2 years ago

deep-diver commented 2 years ago

Closes #41

in this PR, I updated the notebook to run inference on

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

deep-diver commented 2 years ago

@sayakpaul

this notebook shows how to run inference on Vertex Endpoint as well. Do you think it is better to create a separate notebook? In my opinion, it is OK to go with a single file (maybe change the filename). WDYT?

sayakpaul commented 2 years ago

@sayakpaul

this notebook shows how to run inference on Vertex Endpoint as well. Do you think it is better to create a separate notebook? In my opinion, it is OK to go with a single file (maybe change the filename). WDYT?

Sounds good to me. But what about the CONCRETE_INPUT fix?

deep-diver commented 2 years ago

I have to say sorry that CONCRETE_INPUT was fixed without a PR today's afternoon. I thought it's a so simple issue since we could simply set CONCRETE_INPUT to transform_name(IMAGE_KEY), and I just did.

Anyways, my apologies, and I will make sure to create PRs on any issues in the future.

sayakpaul commented 2 years ago

I have to say sorry that CONCRETE_INPUT was fixed without a PR today's afternoon. I thought it's a so simple issue since we could simply set CONCRETE_INPUT to transform_name(IMAGE_KEY), and I just did.

Anyways, my apologies, and I will make sure to create PRs on any issues in the future.

No worries. Glad it was resolved.

deep-diver commented 2 years ago

addressed your comments!