search

defucilis / funscript-io

A website for all things funscript-related: discovery, playback, creation and modification
32 stars 5 forks source link

Add ease in/out balance to "auto" cycler #12

Closed FleetingOrchard closed 3 years ago

FleetingOrchard commented 3 years ago

Adds a 0%-100% slider to the cycler, which moves the point at which the cycler transitions from easing in, to easing out (ergo, moves the point of maximum speed during the cycle). This implementation maintains the current exponential ease in/out curves, but determines their length dynamically depending on the position of that midpoint.

Mostly just wanted this myself, figured I'd kick a PR up in case it interests you.

defucilis commented 3 years ago

Oh yeah this is nice - thanks for contributing!

Could I just ask you to do a couple of things before I merge it:

  1. Run npm run format to fix up the styling
  2. Rename trshold to threshold
  3. Add the following to src/lib/CHANGELOG.ts (starting from line 3, feel free to change the feature description if you like)
## v0.9.0

### 30th June 2021

#### Added

  * The Cycler now has an ease in / ease out balance slider to control the length and midpoint of the speed curves (contribution from [FleetingOrchard](https://github.com/FleetingOrchard)

---
FleetingOrchard commented 3 years ago

Sure! Done.

FleetingOrchard commented 3 years ago

Oh, and regarding the changelog -- you could probably stick it in an .md and just read it in at runtime, or there's probably a viable way to generate it from git history or the like.

FleetingOrchard commented 3 years ago

Actually, I should also mention; I've hacked together a sort of curve-mode-selector for the cycler as well, but I'm not sure how you'd want that to look (if it interests you at all) — UX/UI has never been my strong suit, alas.

defucilis commented 3 years ago

Thanks!

In terms of the selector, I'll maybe hold off for now, I'm going to be doing a redesign of the site in the forseeable future with tailwind to make it easier to support mobile devices (plus now that I've gotten used to Tailwind on some of my SFW projects I miss it really badly wherever I don't have it haha)

For the changelog, I tried to get reading .md files directly working, but for reasons I can't remember I couldn't get it to play nice. I may have just been rushing though :P