ref(*): refactor chart assembly logic

deis / jenkins-jobs

DSL representations of Jenkins jobs for Deis

MIT License

27 stars 18 forks source link

ref(*): refactor chart assembly logic #346

Closed vdice closed 7 years ago

vdice commented 7 years ago

TODO

[x] test affected pipelines after building Jenkins off of this PR

Closes https://github.com/deis/jenkins-jobs/issues/318 Closes https://github.com/deis/jenkins-jobs/issues/344

deis-bot commented 7 years ago

@mboersma is a potential reviewer of this pull request based on my analysis of git blame information. Thanks @vdice!

vdice commented 7 years ago

This is now ready for review; Jenkins has been and is currently running off this branch (used to wrangle together all ingress-related artifacts and standard pipelines have been checked)

mboersma commented 7 years ago

shell and bats tests look groovy. So does the groovy. And removes ~43 LOC! 👍