search

deitch / jsorm-i18n

i18n library for JavaScript: calendar conversions, timezones, i18n resource bundles, currency rendering
20 stars 2 forks source link

Support for BTC #1

Closed cabbiepete closed 12 years ago

cabbiepete commented 12 years ago

The main thing about BTC (which may apply to other currencies) is that it is formatted to 8 significant figures. i.e.

0.00000001 is valid and 1 BTC is formatted 1.00000000

Would be good to support this.

cabbiepete commented 12 years ago

I have started working an implementation that I was going to do a pull request for but I cannot get the tests running I followed the README.txt but it fails trying to find "./jsorm-i18n-src"

Maybe there is a build process to be done also? Or can I test without build somehow??

deitch commented 12 years ago

cabbiepete,

Yes, it looks like 8 significant figures is not in the current structure. I like the idea of supporting BTC, provided that some radical law enforcement agency doesn't come after me for supporting money laundering and piracy. :-)

Seriously, if you have a fix, love to see it.

Tests: Yes, you need to build it in order to run the tests. The build.xml file in the root is for ant, if you build the target "core" it will be sufficient to place the files there. Just make your changes (in this case) to src/core/currency.js, run the build target core, and it will do the installs.

I would like to see the whole build process move to native node, rather than depending on ant+java, but it is a process, need some time....

Looking forward to your pull.

cabbiepete commented 12 years ago

Right got the build working (after installing jsmin and jslint jar files also) and have done the changes and issued the pull request so closing this issue.

deitch commented 12 years ago

Yeah, working to get the whole build working natively in js and node. Not there yet.

On Jan 31, 2012, at 12:08 AM, Peter Simmons reply@reply.github.com wrote:

Right got the build working (after installing jsmin and jslint jar files also) and have done the changes and issued the pull request so closing this issue.

Reply to this email directly or view it on GitHub: https://github.com/deitch/jsorm-i18n/issues/1#issuecomment-3728921