delowardev / vue3-emoji-picker

Simple and Powerful Emoji Picker for Vue3
https://codesandbox.io/p/github/delowardev/vue3-emoji-picker/main?file=%2FREADME.md
MIT License
187 stars 37 forks source link

Prevent submit inside a form. #22

Closed gsvavarsson closed 2 years ago

gsvavarsson commented 2 years ago

Prevent submit when emoji picker is used inside a form.

Context

Currently if picker is embedded in to a form element the undefined buttons submit the form. This change will prevent that by adding type="button"

Summary

Preventing form submission on emoji/group click.

Relevant Technical Choices

Added type="button" to emoji and group buttons.

Checklist

vojtech-houzvicka commented 2 years ago

This would help us a lot 🙏

delowardev commented 2 years ago

Thanks for your contribution, I will publish it to the npm after testing.

gsvavarsson commented 2 years ago

@delowardev thanks for the promp replies. I was using this sandbox for testing (still old package) if you want to check it out.

delowardev commented 2 years ago

A new version has been published to the npm with your changes.

Thanks