search

dennisjenkins75 / digiline_craftdb

Minetest mod for a digiline queryable database holding all regular and technic crafting recipes.
GNU General Public License v3.0
2 stars 2 forks source link

luacontroller in recipe -> depends on mesecons_luacontroller #2

Open SwissalpS opened 3 years ago

SwissalpS commented 3 years ago

https://github.com/dennisjenkins75/digiline_craftdb/blob/ca28bf06e35608f4f1bb4e74caba9440ee2dc077/mod.conf#L3

adding "mesecons_luacontroller" to dependencies is the easy fix.

Nicer fix is to add to optionals and add an alternative recipe for servers that don't have luacontroller. This is a bit weird because lua tube is provided by mesecons base mod. (digilines has mesecons as dependency).

I don't know if any server would have digilines but not luacontroller, just smth I recognized while looking at recipe.

Edit: the technic that pandorabox uses is dependant on pipeworks, so here it would not be needed. I did not check the dependencies of the other technic mod. So better safe and leave it in.

dennisjenkins75 commented 3 years ago

I added "mesecons_luacontroller" as a required dependency. I find it weird that someone would try to use this mod without a luac, but I suppose that they could use a lua sorting tube as their main lua controller. I'll leave this issue open so that we can add a proper fix (alternative recipes, as you suggested). PRs are welcome.