dm-5343 Fellow bio form & show page visual updates - Githubissues

department-of-veterans-affairs / diffusion-marketplace

Diffusion Marketplace source code

https://marketplace.va.gov

7 stars 10 forks source link

dm-5343 Fellow bio form & show page visual updates #1131

Closed PhilipDeFraties closed 1 week ago

PhilipDeFraties commented 1 week ago

JIRA issue link

https://agile6.atlassian.net/browse/DM-5343

Description - what does this code do?

Changes User col :credentials to :fellowship Rearranges a few fields / elements in the /edit-profile and /bios/{user.name_slug} views

Testing done - how did you test it/steps on how can another person can test it

Update a user to grant public bio: user.update!(granted_public_bio: true)
Log in as that user and goo to /edit-profile
Verify the fields lineup with the updated design and persist when updated
Go to the bio page for that user by clicking the "View Public Profile" button at the top of the form
Verify the elements line up with the current design

Screenshots, Gifs, Videos from application (if applicable)

Screenshot 2024-11-21 at 2 28 15 PM

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

[ ]

Definition of done

[ ] Unit tests written (if applicable)
[ ] e2e/accessibility tests written (if applicable)
[ ] Events are logged appropriately
[ ] Documentation has been updated, if applicable
[ ] A link has been provided to the originating JIRA issue
[ ] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs…fellowship