SEARCH RESULTS - Pagination

rickleegit commented 8 years ago

Need a way to paginate the search results. A few considerations:

FE Filtering effects result count and subsequently page count.
Not opposed to a lazy load if it is both 508 compliant and responds to filter inputs (although in thinking that through, this will likely face the same challenges as any pagination solution)
There is no way around some form of pagination. If necessary, we may need to trigger a page reload to accomplish it. As unfortunate as this would be, it might be a more acceptable LOE than trying to integrate with FE filtering. I looked at amazon and home depot as analogs. They both seem to be pinging the server following engagement with the filters - Amazon reloads, Home Depot appears to be working some Ajaxy pixie dust.
No pressure, but the filtering is a core part of the functionality, so if additional brain power is needed to pull this off in a usable manner, let's assemble it sooner than later. :-)

jeffmaher commented 8 years ago

Will start on first thing Friday morning (10/30)

rickleegit commented 8 years ago

@emilyville - we are fortunate enough to have some Jeff time!! Based on Marc's needs and the fact that we may need to resolve this with some back-end filtering/sorting, it made sense to ask Jeff to take this on. But there is plenty that we could use your help with. When you are ready to get started, let's chat. I know you said you have a busy morning, so maybe later this afternoon?

@mphprogrammer - Please work with Jeff to resolve the BE/FE dilemma ASAP. The only wish I have for this would be to consider any possible performance issues with our rudimentary db. The filtration/sort can be a reload, but it needs to be quick. We will lose much of the comparison functionality if the latency is too great. Maybe it won't be a problem, but I wanted to make sure that is on the radar.

Thanks all!!!

Rick

mphprogrammer commented 8 years ago

Had some thoughts on pagination, sorting, and filtering. If you want to do both on the front end, apply the filtering first on the set of schools returned from the search this will mark schools as visible or not. Then, apply the sorting criteria to the set of visible schools, and lastly apply a separate pagination "filter" to the set of sorted visible schools. Take whatever schools are left visible and display. Just my 2 cents.

The DB is rudimentary yet, but, its small - about 33K records in the institution table. It wouldn't take terribly long for the back end to do this either.

I am not a front end coding pro by a long shot, I leave it to your expertise, Jeff!! Thanks!!!!!

jeffmaher commented 8 years ago

Tasks I'm working on:

[x] Make the search action API-accessible ( #48 )
[x] Add pagination for the API (#52)
[x] Make the institution search page use the API, w/ existing UI (#52)
[ ] Make the institution search page use the API with pagination

jeffmaher commented 8 years ago

@rickleegit : Do you have any mockups for how you'd like the pagination to look?

rickleegit commented 8 years ago

Sorry for the delay on this. Was on a call.

I am not terribly particular. Looking for standard pagination features:

Number page links
back/next
jump to end/jump to start
Bonus: Results per page.

That said, If any of that is more difficult or less efficient to implement, we will take what we can get. :-)

Thanks!!

rickleegit commented 8 years ago

This might work but it is messing with the filters pretty severely. I am hoping that we haven't created some sort of filter loop-ish thing.

The pagination should only be effected by the filters. Not a duplex thing. As it is, the filters respond to the itms on the page. So they change as I navigate through the pages, which we do not want.

THANKS FOR DOING THIS! If we can get that behavior fixed it, will be fine!

westurner commented 7 years ago

From https://veterans.uservoice.com/forums/330333-vets-gov/suggestions/17635243-fix-pagination-n-divmod-n-per-page

BUG: GI Bill Comparison Tool: search result pagination is off.

Search query: "Omaha"

First it shows 5 results pages for 67 results, Then when I click on 5 (for things starting with University), It shows 1, 2 and Next. Next works, but the pagination is off.

To clarify, this is w/ Android 6 Chrome 55

Should I create a new issue?

ayaleloehr commented 7 years ago

A separate issue would be great @westurner ! thanks!

westurner commented 7 years ago

@ayaleloehr I've created a new issue: https://github.com/department-of-veterans-affairs/gi-bill-comparison-tool/issues/455

department-of-veterans-affairs / gi-bill-comparison-tool

SEARCH RESULTS - Pagination #36