search

department-of-veterans-affairs / gi-bill-comparison-tool

Rails delivered version of the GI Comparision Tool.
7 stars 9 forks source link

Fixing linting violations #464

Closed knkski closed 7 years ago

saneshark commented 7 years ago

@mphprogrammer Ken has added Jenkins integration + rubocop linting, etc to this repo. I will do a quick look over the rubocop changes, but could you please take a look as well sometime in the AM tomorrow so that we can try to get these changes merged.

knkski commented 7 years ago

@saneshark, @mphprogrammer: Anything holding this back, or can we merge this?

mphprogrammer commented 7 years ago

@knkski Nothing that I know of ... took a quick peek at the changes, but nothing issue-wise leapt off the page.

saneshark commented 7 years ago

@knkski I don't really see any problem with this either, but I also don't see it as particularly pressing as most of our focus and efforts are now with the gibct-data-service and the vets-website changes that will replace this repo.

saneshark commented 7 years ago

Other than some kind of bug fix, until we can get rid of the repo altogether, I don't anticipate us really working in this repo very much moving forward.

knkski commented 7 years ago

Sure. I'll merge so that the Jenkins builds work, but won't do anything beyond that