derfloh205 / CraftSim

MIT License
14 stars 37 forks source link

LUA error when opening work order or profession page #56

Closed hollo6 closed 1 year ago

hollo6 commented 1 year ago

I get these when opening work orders for: Primal Molten Longsword, Primal Molten Pauldrons. Not sure what triggers it, previously opening the work order for the shoulders didn't give this error.

1x ...rfaceCraftSim/Data/SpecNodeData/SpecData.lua:152: CraftSim Error: Node ID not implemented: 23911 string "=[C]": in function error' [string "@CraftSim/Data/SpecNodeData/SpecData.lua"]:152: in functionGetStatsFromSpecNodeData' [string "@CraftSim/Data/DataExport.lua"]:247: in function handlePlayerProfessionStatsV2' [string "@CraftSim/Data/DataExport.lua"]:359: in functionhandlePlayerProfessionStats' [string "@CraftSim/Data/DataExport.lua"]:863: in function exportRecipeData' [string "@CraftSim/Main/CraftSim.lua"]:435: in functionTriggerModulesByRecipeType' [string "@CraftSim/Main/CraftSim.lua"]:169: in function `TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:202: in function <CraftSim/Main/CraftSim.lua:187>

string "=[C]": in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185> [string "=[C]"]: in functionShow' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:766: in function `ViewOrder' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:63: in function <...Professions/Blizzard_ProfessionsCrafterOrderPage.lua:58>

Locals: (*temporary) = "CraftSim Error: Node ID not implemented: 23911"

hollo6 commented 1 year ago

This one popped up when opening the profession page:

1x ...rfaceCraftSim/Data/SpecNodeData/SpecData.lua:152: CraftSim Error: Node ID not implemented: 19484 string "=[C]": in function error' [string "@CraftSim/Data/SpecNodeData/SpecData.lua"]:152: in functionGetStatsFromSpecNodeData' [string "@CraftSim/Data/DataExport.lua"]:247: in function handlePlayerProfessionStatsV2' [string "@CraftSim/Data/DataExport.lua"]:359: in functionhandlePlayerProfessionStats' [string "@CraftSim/Data/DataExport.lua"]:885: in function exportRecipeData' [string "@CraftSim/Main/CraftSim.lua"]:435: in functionTriggerModulesByRecipeType' [string "@CraftSim/Main/CraftSim.lua"]:169: in function `TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:202: in function <CraftSim/Main/CraftSim.lua:187>

string "=[C]": in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185> [string "=[C]"]: in functionShow' ... [string "@FrameXML/SecureTemplates.lua"]:690: in function <FrameXML/SecureTemplates.lua:672> [string "@FrameXML/SecureTemplates.lua"]:704: in function <FrameXML/SecureTemplates.lua:697> [string "@FrameXML/SecureTemplates.lua"]:746: in function `SecureActionButton_OnClick' [string "@FrameXML/ActionButton.lua"]:1155: in function <FrameXML/ActionButton.lua:1125>

[string "@FrameXML/SecureHandlers.lua"]:266: in function <FrameXML/SecureHandlers.lua:263>

[string "@FrameXML/SecureHandlers.lua"]:296: in function <FrameXML/SecureHandlers.lua:279>

Locals: (*temporary) = "CraftSim Error: Node ID not implemented: 19484"

derfloh205 commented 1 year ago

on what CraftSim Version does this happen for u?

hollo6 commented 1 year ago

Latest, it was 6.1 at the time. I see there were a few updates yesterday, I just installed 6.2.3, will test with this version and report back.

hollo6 commented 1 year ago

Not sure if related, now I get this when opening a profession page:

2x CraftSim/Util/Util.lua:73: bad argument #1 to 'find' (string expected, got nil) string "=[C]": in function find' [string "@CraftSim/Util/Util.lua"]:73: in functionGetItemIDByLink' [string "@CraftSim/Data/DataExport.lua"]:844: in function exportRecipeData' [string "@CraftSim/Main/CraftSim.lua"]:435: in functionTriggerModulesByRecipeType' [string "@CraftSim/Main/CraftSim.lua"]:169: in function `TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:202: in function <CraftSim/Main/CraftSim.lua:187>

string "=[C]": in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185> [string "=[C]"]: in functionSetShown' [string "@SharedXML/TabSystem/TabSystemOwner.lua"]:33: in function SetTab' [string "@SharedXML/TabSystem/TabSystemOwner.lua"]:69: in functionSetTab' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:368: in function SetTab' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:251: in functionUpdateTabs' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:196: in function Refresh' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:158: in functionSetProfessionInfo' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:96: in function <...s/Blizzard_Professions/Blizzard_ProfessionsFrame.lua:59>

Locals: (temporary) = nil (temporary) = "item:(%d+)" (*temporary) = "string expected, got nil"

hollo6 commented 1 year ago

And this one when switching to the Crafting Orders tab:

4x CraftSim/Util/Util.lua:73: bad argument #1 to 'find' (string expected, got nil) string "=[C]": in function find' [string "@CraftSim/Util/Util.lua"]:73: in functionGetItemIDByLink' [string "@CraftSim/Data/DataExport.lua"]:844: in function exportRecipeData' [string "@CraftSim/Main/CraftSim.lua"]:435: in functionTriggerModulesByRecipeType' [string "@CraftSim/Main/CraftSim.lua"]:169: in function `TriggerModulesErrorSafe' [string "@CraftSim/Main/CraftSim.lua"]:202: in function <CraftSim/Main/CraftSim.lua:187>

string "=[C]": in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:191: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:185> [string "=[C]"]: in functionSetShown' [string "@SharedXML/TabSystem/TabSystemOwner.lua"]:33: in function SetTab' [string "@SharedXML/TabSystem/TabSystemOwner.lua"]:69: in functionSetTab' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:368: in function SetTab' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:251: in functionUpdateTabs' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:196: in function Refresh' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:158: in functionSetProfessionInfo' [string "@Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:96: in function <...s/Blizzard_Professions/Blizzard_ProfessionsFrame.lua:59>

Locals: (temporary) = nil (temporary) = "item:(%d+)" (*temporary) = "string expected, got nil"

hollo6 commented 1 year ago

debug output for the first one (opening profession page):

recipeinfo isEnchantingRecipe: true disabled: false relativeDifficulty: 3 recipeID: 55016 supportsCraftingStats: false firstCraft: false categoryID: 742 isGatheringRecipe: false learned: true skillLineAbilityID: 19545 icon: 136243 favoritesInstance: true isSalvageRecipe: false itemLevel: 0 numSkillUps: 1 craftable: true sourceType: 0 isRecraft: false canSkillUp: false maxTrivialLevel: 35 hasSingleItemOutput: false name: Nitro Boosts supportsQualities: false isDummyRecipe: false alternateVerb: Tinker favorite: true canCreateMultiple: true Init: 55016 Export Mode: 0

hollo6 commented 1 year ago

debug output for switching to Crafting Orders tab:

Update: 55016 Export Mode: 0

hollo6 commented 1 year ago

This when crafting an item (on craft finish):

3x ...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:269: attempt to index field 'stats' (a nil value) [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:269: in function `processCraftResults' [string "@CraftSim/Modules/CraftResults/CraftResults.lua"]:217: in function <...ddOns/CraftSim/Modules/CraftResults/CraftResults.lua:216>

Locals: self = Frame { 0 = GetProfitForCraft = defined @CraftSim/Modules/CraftResults/CraftResults.lua:183 baseRecipeEntry =

{ } TRADE_SKILL_CRAFT_BEGIN = defined @CraftSim/Modules/CraftResults/CraftResults.lua:160 TRADE_SKILL_ITEM_CRAFTED_RESULT = defined @CraftSim/Modules/CraftResults/CraftResults.lua:210 currentCrafts = 0 currentRecipeData =
{ } sessionData =
{ } FRAMES =
{ } AddResult = defined @CraftSim/Modules/CraftResults/CraftResults.lua:339 processCraftResults = defined @CraftSim/Modules/CraftResults/CraftResults.lua:222 ExportCSV = defined @CraftSim/Modules/CraftResults/CraftResults.lua:39 ResetData = defined @CraftSim/Modules/CraftResults/CraftResults.lua:35 AddCraftData = defined @CraftSim/Modules/CraftResults/CraftResults.lua:97 } craftingResults =
{ 1 =
{ } } recipeData =
{ hasReagentsWithQuality = false isEnchantingRecipe = false possibleSalvageReagents =
{ } recipeID = 251808 ContinueOnResultItemsLoaded = defined @CraftSim/Data/DataExport.lua:884 supportsCraftingStats = false currentTransaction =
{ } numSkillUps = 1 categoryID = 608 learned = true isRecraft = false result =
{ } baseItemAmount = 1 isSalvageRecipe = false hasSingleItemOutput = false recipeName = "Transmute: Meat to Pet" professionID = 3 possibleFinishingReagents =
{ } finishingReagents =
{ } recipeType = 6 optionalReagents =
{ } numReagentsWithQuality = 0 professionInfo =
{ } possibleOptionalReagents =
{ } recipeIcon = 237328 subtypeID = 11 reagents =
{ } } craftData =
{ recipeName = "Transmute: Meat to Pet" recipeID = 251808 quantityImportant = false expectedAverageProfit = 0 procs =
{ } profit = 0 results =
{ } } (temporary) = nil (temporary) =
{ triggered = false savedReagents =
{ } } (temporary) =
{ } (temporary) =
{ 1 =
{ } } (temporary) = 1 (temporary) = nil (temporary) = nil (temporary) = nil (temporary) =
{ qualityProgress = 0 firstCraftReward = false critBonusSkill = 0 hyperlink = "|cff1eff00|Hitem:160325::::::::70:258:::::::::|h[Quivering Sac]|h|r" itemGUID = "Item-3682-0-40000009E2E5F3A9" multicraft = 0 quantity = 1 itemID = 160325 isCrit = false recraftable = false operationID = 0 isEnchant = false bonusCraft = false } (temporary) = false (temporary) = defined =[C]:-1 (temporary) =
{ qualityProgress = 0 recraftable = false critBonusSkill = 0 firstCraftReward = false itemGUID = "Item-3682-0-40000009E2E5F3A9" multicraft = 0 quantity = 1 itemID = 160325 isCrit = false hyperlink = "|cff1eff00|Hitem:160325::::::::70:258:::::::::|h[Quivering Sac]|h|r" operationID = 0 isEnchant = false bonusCraft = false } (temporary) = "bonusCraft" (temporary) = "attempt to index field 'stats' (a nil value)" collectingResults = true print = defined @CraftSim/Util/Util.lua:11 currentCraftingResults =
{ }

derfloh205 commented 1 year ago

might be fixed with the backend rework. if this is still occuring please open another issue