search

derfloh205 / CraftSim

MIT License
14 stars 37 forks source link

2-5 second freezes every time I do anything related to work orders in craft sim #561

Closed Fexxu closed 2 weeks ago

Fexxu commented 1 month ago

as the title states, when I optimize materials on a craft order my game freezes for 5 seconds. it even freezes when I just open the craftorder. Id post a bucksack report but there is none produced when this freeze shows up.

derfloh205 commented 1 month ago

need more info:

Fexxu commented 1 month ago

Version: current one from curseforge: 18.2.1 what crafting order recipes: any profession: Alchemy and Inscription. (Doesnt happen at all on a character with jewelcrafting and enchanting)

Fexxu commented 1 month ago

It also happens with no other addons enabled (not even one of the price sources), I've also tried with only TSM and only Auctionator alongside it but the freezes remain the same.

StanoRiga commented 4 weeks ago

same here (profession enchanting and tailoring), but only if I add crafting reagent like "Bottled Brilliance"

Fexxu commented 4 weeks ago

for me even without those, i could open the most basic crafting order and it freezes for 3 seconds then I check the simulation mark, another freeze for 5 seconds and every time I try to adjust the materials in the simulation it freezes for 5 seconds. even when I just increase one of the materials by 1

derfloh205 commented 4 weeks ago

that is most certainly due to sub recipe optimization toggled on in the cost optimization module

Fleymour commented 4 weeks ago

2x CraftSim/Classes/ProfessionGear.lua:25: script ran too long [string "@CraftSim/Classes/ProfessionGear.lua"]:25: in function Equals' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:125: in functionfindFunc' [string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:111: in function Find' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:105: in functionGetUniqueCombosFromAllPermutations' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:293: in function GetProfessionGearCombinations' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:339: in functionOptimizeTopGear' [string "@CraftSim/Classes/RecipeData.lua"]:607: in function OptimizeGear' [string "@CraftSim/Classes/RecipeData.lua"]:639: in functionOptimizeProfit' [string "@CraftSim/Classes/RecipeData.lua"]:1158: in function OptimizeSubRecipes' [string "@CraftSim/Init/Init.lua"]:544: in functionTriggerModulesByRecipeType' [string "@CraftSim/Init/Init.lua"]:85: in function <CraftSim/Init/Init.lua:83> [string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:605: in function checkCondition' [string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:611: in functionWaitFor' [string "@CraftSim/Init/Init.lua"]:74: in function `TriggerModuleUpdate' [string "@CraftSim/Init/Init.lua"]:69: in function <CraftSim/Init/Init.lua:68>

Locals: self =

{ professionStats =
{ } item =
{ } } professionGear =
{ professionStats =
{ } item =
{ } } itemLinkA = "|cffa335ee|Hitem:191228:6664:::::::80:72::13:4:8844:8842:8807:8862:5:28:2164:29:76:38:8:40:147:46:198536::::|h[Black Dragon Touched Hammer |A:Professions-ChatIcon-Quality-Tier5:17:17::1|a]|h|r" itemLinkB = "|cff1eff00|Hitem:222486::::::::80:72::13:3:10827:10830:9632:4:28:2734:29:80:38:8:40:2193::::|h[Proficient Blacksmith's Hammer |A:Professions-ChatIcon-Quality-Tier5:17:17::1|a]|h|r" (temporary) = "|cff1eff00|Hitem:222486::::::::80:72::13:3:10827:10830:9632:4:28:2734:29:80:38:8:40:2193::::Player-581-0CECF3CF:|h[Proficient Blacksmith's Hammer |A:Professions-ChatIcon-Quality-Tier5:17:17::1|a]|h|r" (temporary) = "Player.-:" (temporary) = "" (temporary) = "script ran too long"

Fleymour commented 4 weeks ago

1x CraftSim/Modules/TopGear/TopGear.lua:133: script ran too long [string "@CraftSim/Modules/TopGear/TopGear.lua"]:133: in function findFunc' [string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:111: in functionFind' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:105: in function GetUniqueCombosFromAllPermutations' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:293: in functionGetProfessionGearCombinations' [string "@CraftSim/Modules/TopGear/TopGear.lua"]:339: in function OptimizeTopGear' [string "@CraftSim/Classes/RecipeData.lua"]:607: in functionOptimizeGear' [string "@CraftSim/Classes/RecipeData.lua"]:639: in function OptimizeProfit' [string "@CraftSim/Classes/RecipeData.lua"]:1158: in functionOptimizeSubRecipes' [string "@CraftSim/Init/Init.lua"]:544: in function TriggerModulesByRecipeType' [string "@CraftSim/Init/Init.lua"]:85: in function <CraftSim/Init/Init.lua:83> [string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:605: in functioncheckCondition' [string "@CraftSim/Libs/GUTIL/GUTIL.lua"]:611: in function WaitFor' [string "@CraftSim/Init/Init.lua"]:74: in functionTriggerModuleUpdate' [string "@CraftSim/Init/Init.lua"]:126: in function <CraftSim/Init/Init.lua:106>

string "=[C]": in function Init' [string "@Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:192: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:186> [string "=[C]"]: in functionShow' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:759: in function `ViewOrder' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:64: in function <...Professions/Blizzard_ProfessionsCrafterOrderPage.lua:59>

Locals: comboB =

{ 1 =
{ } 2 =
{ } 3 =
{ } } toolB =
{ professionStats =
{ } item =
{ } } gear1B =
{ professionStats =
{ } item =
{ } } gear2B =
{ professionStats =
{ } item =
{ } } existsGear1 = false existsGear2 = false existsTool = false (temporary) = false (temporary) =
{ professionStats =
{ } item =
{ } } (temporary) =
{ professionStats =
{ } item =
{ } } (temporary) = "script ran too long" isCooking = false gear1A =
{ professionStats =
{ } item =
{ } } EMPTY = "EMPTY_SLOT" gear2A =
{ professionStats =
{ } item =
{ } } toolA =
{ professionStats =
{ } item =
{ } }

Fleymour commented 4 weeks ago

craftsim: 17.2.1.1 fine workorders: LW, engineering, tailoring slow but no LUA: inscr, alch LUA : blacksmith

edit1: but wait... why i have this old version (i update daily)... oof curseforge even dont know i have installed that addon. what happend there -.-

edit2: installed / updated to 18.2.2 same issue with freeze "1x CraftSim/Classes/ProfessionGear.lua:24: script ran too long" weirdly i have 3 blacksmiths and yesterday i had 0 issues... but today i have this for first time.. did blizzard changed something? its fine when we open the crafting table. the first lagg occures when i swap to "crafting orders" and the 2nd lagg comes when i click into a crafting order or when i swap back to the recipe category out of a workorder.

king-amin01 commented 4 weeks ago

have same issue last night and today too my game freeze like 10 sec on crafting order and simulation and also everytime want add any finishing reagents (tailoring - blacksmithing - alchemy - jewelcraft - leatherwork)

addon version : 18.2.2

Fexxu commented 3 weeks ago

that is most certainly due to sub recipe optimization toggled on in the cost optimization module

yep, this is it. I turned it off and everythings fine again. I cant remember that I ever turned it on

wingfield65 commented 3 weeks ago

I have the same issue; but I can't get to the cost optimization module to turn this off since it freezes the game whenever I get into the crafting window.

version : 18.2.3 profession : BS expansion : TWW

Message: Interface/AddOns/CraftSim/Classes/ProfessionGear.lua:24: script ran too long Time: Sat Sep 28 08:51:18 2024 Count: 1 Stack: Interface/AddOns/CraftSim/Classes/ProfessionGear.lua:24: script ran too long

[string "@Interface/AddOns/CraftSim/Classes/ProfessionGear.lua"]:24: in function Equals' [string "@Interface/AddOns/CraftSim/Modules/TopGear/TopGear.lua"]:120: in functionfindFunc' [string "@Interface/AddOns/CraftSim/Libs/GUTIL/GUTIL.lua"]:111: in function Find' [string "@Interface/AddOns/CraftSim/Modules/TopGear/TopGear.lua"]:105: in functionGetUniqueCombosFromAllPermutations' [string "@Interface/AddOns/CraftSim/Modules/TopGear/TopGear.lua"]:293: in function GetProfessionGearCombinations' [string "@Interface/AddOns/CraftSim/Modules/TopGear/TopGear.lua"]:339: in functionOptimizeTopGear' [string "@Interface/AddOns/CraftSim/Classes/RecipeData.lua"]:965: in function OptimizeGear' [string "@Interface/AddOns/CraftSim/Classes/RecipeData.lua"]:994: in functionOptimizeProfit' [string "@Interface/AddOns/CraftSim/Classes/RecipeData.lua"]:1539: in function OptimizeSubRecipes' [string "@Interface/AddOns/CraftSim/Init/Init.lua"]:588: in functionTriggerModulesByRecipeType' [string "@Interface/AddOns/CraftSim/Init/Init.lua"]:85: in function <Interface/AddOns/CraftSim/Init/Init.lua:83> ... [string "@Interface/AddOns/Blizzard_ProfessionsTemplates/Blizzard_ProfessionsRecipeSchematicForm.lua"]:192: in function <...emplates/Blizzard_ProfessionsRecipeSchematicForm.lua:186> string "=[C]": in function SetShown' [string "@Interface/AddOns/Blizzard_SharedXML/Mainline/TabSystem/TabSystemOwner.lua"]:33: in functionSetTab' [string "@Interface/AddOns/Blizzard_SharedXML/Mainline/TabSystem/TabSystemOwner.lua"]:69: in function `SetTab' [string "@Interface/AddOns/Blizzard_Professions/Blizzard_ProfessionsFrame.lua"]:449: in function <...s/Blizzard_Professions/Blizzard_ProfessionsFrame.lua:348>

[string "@Interface/AddOns/Blizzard_SharedXML/Mainline/TabSystem/TabSystemTemplates.lua"]:175: in function `SetTab' [string "@Interface/AddOns/Blizzard_SharedXML/Mainline/TabSystem/TabSystemTemplates.lua"]:98: in function <..._SharedXML/Mainline/TabSystem/TabSystemTemplates.lua:95>

Locals:

derfloh205 commented 3 weeks ago

@wingfield65 try /run CraftSimAPI:GetCraftSim().DB.OPTIONS:Save("COST_OPTIMIZATION_AUTOMATIC_SUB_RECIPE_OPTIMIZATION", false)

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.