derrian-distro / LoRA_Easy_Training_Scripts

A UI made in Pyside6 to make training LoRA/LoCon and other LoRA type models in sd-scripts easy
GNU General Public License v3.0
1.06k stars 103 forks source link

When using DAdaptation the output Loras are ‘blanks’ #153

Closed thavocado closed 11 months ago

thavocado commented 11 months ago

No problems with Adam. Output Loras have no effect on generated image. No such issues with Kohya. Using default reasonable settings.

Jelosus2 commented 11 months ago

Have you added decouple as true in the optimizer arguments?

thavocado commented 11 months ago

Thanks for the reply.

I didn’t set that option at all.

Could that be the cause of the problem?

Jelosus2 commented 11 months ago

yea, i know someone that tried using Dadap without that argument and got a similar problem

Jelosus2 commented 11 months ago

Kohya has like default arguments for each optimizer but this trainer has the same for every one so you need to apply the needed ones by yourself

thavocado commented 11 months ago

Thanks a lot! I’ll give it a test tomorrow!

Jelosus2 commented 11 months ago

no problem :) let me know if your issue still persists

derrian-distro commented 11 months ago

I know my scripts work fine with dadapt, though I personally don't use it. All that my ui does is just pass args to kohya, do some validation, and generally tries to make things a bit easier for people. I've had somebody else just state that it works yesterday as well, so it's very possibly because of your args

thavocado commented 11 months ago

So turns out I was using DAdaptAdam and that setting decouple to true absolutely produces working Loras now! Woo! Thank you so much for your help! ❤️🥳

derrian-distro commented 11 months ago

Alright, I'm going to close this issue now, then. I should probably force decouple to be on for dadapt so people don't need to worry about it.

Jelosus2 commented 11 months ago

So turns out I was using DAdaptAdam and that setting decouple to true absolutely produces working Loras now! Woo! Thank you so much for your help! ❤️🥳

Great! Nice that you solved it. Also yes, i too also think using decouple as default on Dadap can be a good thing so people isn't confused and there's not a lot of issues open here because of that :D