designeerlabs / discord-vr

discord voice chat overlay for openvr
Other
52 stars 5 forks source link

Non-Chrome Chromium installations result in "unknown error: Cannot find Chrome binary" #17

Open KiraSlith opened 1 year ago

KiraSlith commented 1 year ago

What's the issue: Discord-VR cannot find the Chrome binary for chromium alternatives Who does it affect: Brave users, OperaGX users, Chromium users, De-Googled Chrome users, and others. What's the desired outcome: Allow directing to user-chosen chrome-compatible binaries.

My theoretical solve: ChromeDriver supports being pointed to specific Chrome instance in it's options call before initializing the chrome session:

options.setBinary("/path/to/other/chrome/binary");

Setup a variable in "discord-vr\DiscordVR_Data\StreamingAssets\config.json", then check the contents of that variable, if it's blank don't initialize that option so ChromeDriver follows it's automatic routine for finding Chrome, if not load the variable in place of "/path/to/other/chrome/binary" in the example, so ChromeDriver can load a user-chosen chrome binary if needed. Ideally you'd catch the error and ask the user for a chrome directory in-app, but having it only be a variable in config.json would be a low-hanging solution.

KiraSlith commented 1 year ago

Title updated to better fit the context of the bug.