destination-earth / DestinE_ESA_GFTS

Global Fish Tracking Service - DestinE DESP Use Case
https://destination-earth.github.io/DestinE_ESA_GFTS/
Apache License 2.0
10 stars 6 forks source link

Adding notebooks for the data formatting and for the execution of multiple parametrized notebooks. #58

Closed aderrien7 closed 2 months ago

aderrien7 commented 2 months ago

data_conversion.py : Contains all the functions for formatting files in pangeo-fish format data_formatting.ipynb : Notebook that showcase how the formatting works and ends with the routine to convert all the raw files pangeo-fish_papermill .ipynb: Template notebook executing all the pangeo algorithm through one file papermill_launcher.ipynb : Launcher that uses the template notebook with a given set of parameters

tinaok commented 2 months ago

@annefou do you have any idia why the check fails?

aderrien7 commented 2 months ago

Template has been removed in order to access it from pangeo-fish directly. Still need to do a small modification for the papermill_launcher.ipynb notebook and it should be ready to be merged

aderrien7 commented 2 months ago

Should be ready to be merged now

aderrien7 commented 2 months ago

The pre-commit is not working because of the import of hvplot.xarray in pannel_plot_s3.ipynb. It's detected has an unused import but it's mandatory to enable the .hvplot method used from xarrray object.

annefou commented 2 months ago

The pre-commit is not working because of the import of hvplot.xarray in pannel_plot_s3.ipynb. It's detected has an unused import but it's mandatory to enable the .hvplot method used from xarrray object.

I think you can add # noqa to avoid the pre-commit test to fail:

import hvplot.xarray  # noqa
tinaok commented 2 months ago

update papermil template to the default pangeo_fish notebook