destination-earth / DestinE_ESA_GFTS

Global Fish Tracking Service - DestinE DESP Use Case
https://destination-earth.github.io/DestinE_ESA_GFTS/
Apache License 2.0
10 stars 6 forks source link

add users from VLIZ #93

Closed tinaok closed 4 weeks ago

tinaok commented 1 month ago

We will start to use add more users.
How do we want to proceed?

Can we make a procedure for clearing new users?

annefou commented 1 month ago

@tinaok What level of access does davidcasalsVLIZ need for the S3 buckets?

Read-only access to the gfts-reference-data and destine-gfts-data-lake S3 buckets? Or is there a need for write access as well?

What about the Ifremer bucket? Does he need read/write access to the gfts-ifremer bucket?

tinaok commented 1 month ago

Thank you Anne,

Read-only access to the gfts-reference-data and destine-gfts-data-lake S3 buckets? Or is there a need for write access as well? yes, read only there.

annefou commented 4 weeks ago

@minrk I tried to add the new buckets gfts-vliz and vliz_users. Could you check if everything is set up correctly, and that I haven’t messed up anything? Thanks!

minrk commented 4 weeks ago

Can we make a procedure for clearing new users?

We do have a procedure here.

We can add docs for creating the buckets for new users.

@annefou looks right! I noticed a couple things that needed fixing in #93, and I'll apply those here as well (mainly a default deny permission that seems like it is supposed to be the s3 default, but isn't when I test).

annefou commented 4 weeks ago

We can add docs for creating the buckets for new users.

Do you mean that gfts-vliz needs to be created manually and separately? Or do you mean I should document the process of adding a new bucket in the doc https://destination-earth.github.io/DestinE_ESA_GFTS/admin_hub.html ?

minrk commented 4 weeks ago

Do you mean that gfts-vliz needs to be created manually and separately?

No, I mean what you did in this PR, which was exactly right, it is just a lot of copying and pasting we haven't written down yet.

I think it can actually be simplified a bit, too.

minrk commented 4 weeks ago

Any more you want to do here, or ok to merge?

annefou commented 4 weeks ago

For me it is OK to merge.

minrk commented 4 weeks ago

ok, the bucket exists and the user should have access to the Hub when the github action finishes deploying

annefou commented 4 weeks ago

Perfect! I will add some info on adding new buckets in the doc. Thank you!