search

destination-earth / DestinE_ESA_GFTS

Global Fish Tracking Service - DestinE DESP Use Case
https://destination-earth.github.io/DestinE_ESA_GFTS/
Apache License 2.0
10 stars 6 forks source link

remove redundant read access from s3 user policies #95

Closed minrk closed 4 weeks ago

minrk commented 4 weeks ago

The bucket ACL already grants this permission via AuthenticatedUsers, no need to repeat it a bunch of redundant permissions

@annefou this will affect what you need to write for a new bucket, since less is required

annefou commented 4 weeks ago

Indeed. It is much simpler! Thank you.

minrk commented 4 weeks ago

In general, the Bucket ACLs and user policies are almost redundant. We shouldn't need both, but I need to do some testing to figure out if we can safely replace them. Ideally, Object Acls would be disabled (the AWS default and recommended behavior), but OVH doesn't seem to allow that.

minrk commented 4 weeks ago

I think I have a way to simplify this further and also test it, PR momentarily

annefou commented 4 weeks ago

Wow! That would be fantastic! Thank you!