search

det-lab / kaitai_struct_awkward_runtime

Kaitai Struct: runtime for Awkward Arrays
MIT License
2 stars 2 forks source link

Makefile and Github action #19

Closed zonca closed 9 months ago

zonca commented 9 months ago

Add a Makefile that automates the steps in the https://github.com/ManasviGoyal/kaitai_struct_awkward_runtime#readme and executes a simple test on animal.ksy.

Enable a Github Action that executes this test at every commit.

zonca commented 9 months ago

@ManasviGoyal this is just for testing purposes, please do not merge. Can you approve the workflow execution so we can verify if it runs?

ManasviGoyal commented 9 months ago

Hi @zonca , I have made some changes to the kaitai_struct_compiler code with changes the prefix in the generated output. 

[{'animalA__Zentry': [{'animal_entryA__Zstr_len': 3, 'animal_entryA__Zspecies': 'cat', 'animal_entryA__Zage': 5, 'animal_entryA__Zweight': 12}, {'animal_entryA__Zstr_len': 3, 'animal_entryA__Zspecies': 'dog', 'animal_entryA__Zage': 3, 'animal_entryA__Zweight': 43}, {'animal_entryA__Zstr_len': 6, 'animal_entryA__Zspecies': 'turtle', 'animal_entryA__Zage': 10, 'animal_entryA__Zweight': 5}]}]

Please sync fork and make the necessary changes in test. Thanks.

zonca commented 9 months ago

@ManasviGoyal I think this is ready to review, I think it is a good idea to have a development version of the compiler as a submodule of this project, so that we can test changes to both libraries together. Then when we actually make a release, we will only use officially published versions of the kaitai compiler.

zonca commented 9 months ago

this branch started from the test branch, so at some point in the history it had the jar libraries included. However, if we do a "Squash and merge", they will never hit the main branch.

zonca commented 9 months ago

I think this PR could be merged (with "Squash and merge" to avoid having jars in the history)