search

devict / hacktoberfest

Our own little local version of hacktoberfest
https://hacktoberfest.devict.org
5 stars 19 forks source link

feat: when checking PR status the client side current year is shown #92

Closed aaronarduino closed 2 years ago

aaronarduino commented 2 years ago

Fixes issue #91

This might be somewhat of a bandaid fix but I think it should be a reasonable solution for now. The year is now dynamically inserted into the copy from the client side date in Javascript. This obviously has some downsides as it will not track with the server side data past December. However, I think most people visit the site from Sept. to Nov. so it might be okay.

sethetter commented 2 years ago

Agreed -- this looks good enough for the use case, thanks @aaronarduino!

aaronarduino commented 2 years ago

In case you didn't know @sethetter, the rules of the main Hacktoberfest is different this year and for PR's to count towards Hacktoberfest the PR's need to be tagged with HACKTOBERFEST-ACCEPTED or the repo needs the HACKTOBERFEST topic added to it. Relevant link: https://hacktoberfest.com/participation/#pr-mr-details

sethetter commented 2 years ago

@aaronarduino thanks for the heads up!