devkitPro / wut

Let's try to make a Wii U Toolchain / SDK for creating rpx/rpl.
zlib License
244 stars 52 forks source link

cmake: Use include_directories instead of -I cflags #91

Closed ashquarky closed 5 years ago

ashquarky commented 5 years ago

Heyo! Just a small thing - using include_directories instead of -I. This helps some cmake analysers and the like to better get an idea of how wut works, while having the same effect in terms of actual compiling. In my case, it meant the IDEs I was experimenting with would find wut's headers without extra help! If there's some reason this wasn't done initially, I'd be glad to hear it. Not too attached to this change, though it would be nice ;D Thanks again! -Ash

exjam commented 5 years ago

The reason was that I did not realise we could use include_directories from the toolchain file :)

I wonder if we should change the others where possible, like using add_compile_definitions and link_directories ?