devkitPro / wut

Let's try to make a Wii U Toolchain / SDK for creating rpx/rpl.
zlib License
244 stars 52 forks source link

Why BOOL? #94

Closed BullyWiiPlaza closed 5 years ago

BullyWiiPlaza commented 5 years ago

Since the toolchain requires a "modern" C++ compiler, why don't we also use the built-in bool type since it is available? Defining our own BOOL is pointless and only adds an unnecessary layer of complication in my opinion.

wut_types.h:

#pragma once
#include <stdint.h>

typedef int32_t BOOL;

#ifndef TRUE
#define TRUE 1
#endif

#ifndef FALSE
#define FALSE 0
#endif

This may as well be removed and all references updated.

exjam commented 5 years ago

Compiling the tools requires a modern C++ compiler, using the toolchain does not.