devo-ps / pipelines

Build pipelines for automation, deployment, testing...
MIT License
119 stars 13 forks source link

Update from deprecated usage of access_token for GitHub API #108

Closed JuhaS closed 2 years ago

JuhaS commented 4 years ago

Github is deprecating sending access_token as part of querystring, it should be included as "Autorization" header instead.

Reference: https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/#authenticating-using-query-parameters

This line needs to change and instead add it as a header: https://github.com/Wiredcraft/pipelines/blob/dev/pipelines/api/ghauth.py#L122

kaleocheng commented 2 years ago

closing as done