devonfw / IDEasy

Tool to automate the setup and updates of a development environment for any project (Successor of devonfw-ide).
Apache License 2.0
8 stars 18 forks source link

Eclipse plugin installation opens an Eclipse window for each plugin installed #356

Open hohwille opened 3 months ago

hohwille commented 3 months ago

I tested #236 now and found a problem: For every plugin installation IDEasy now opens a new window (Eclipse GUI that appears and then disappears). This should be prevented and was fixed in devonfw-ide 1+ year ago.

I am not yet sure what makes the difference. Somehow related to this old code: https://github.com/devonfw/ide/blob/cdf4af5de21489f3fdcbfdab41af858822e0d598/scripts/src/main/resources/scripts/command/eclipse#L394-L396

hohwille commented 3 months ago

IDEasy with trace-logging gives me this:

Running command 'D:\projects\_ide\software\default\eclipse\eclipse\2024-03\eclipse.exe' with arguments '-data' 'D:\projects\test3\workspaces\main' '-clean' '-keyring' 'C:\Users\hohwille\.eclipse\.keyring' '-configuration' 'D:\projects\test3\plugins\eclipse\configuration' '-consoleLog' '-nosplash' '-vm' 'D:\projects\test3\software\java\bin' '-application' 'org.eclipse.equinox.p2.director' '-repository' 'https://devonfw.com/cobigen/updatesite/stable/' '-installIU' 'com.devonfw.cobigen.eclipse.feature.feature.group,com.devonfw.cobigen.tempeng-freemarker,com.devonfw.cobigen.htmlplugin,com.devonfw.cobigen.javaplugin,com.devonfw.cobigen.jsonplugin,com.devonfw.cobigen.openapiplugin,com.devonfw.cobigen.propertyplugin,com.devonfw.cobigen.textmerger,com.devonfw.cobigen.tsplugin,com.devonfw.cobigen.tempeng-velocity,com.devonfw.cobigen.xmlplugin' ...
hohwille commented 3 months ago

devonfw-ide with trace-logging gives me this:

+++ /d/projects/test-project/software/eclipse/eclipsec -consoleLog -nosplash -configuration /d/projects/test-project/plugins/eclipse/configuration/ -vm /d/projects/test-project/software/java/bin/java -application org.eclipse.equinox.p2.director -repository https://raw.githubusercontent.com/iloveeclipse/plugins/latest/ -installIU AnyEditTools.feature.group -vmargs ''

OK. so the magic trick seems to call eclipsec instead of eclipse to run headless without GUI window. Also found the PR diff meanwhile: https://github.com/devonfw/ide/pull/911/files