Open mvomiero opened 5 months ago
While this sounds like a good idea, the first suggested point IMHO will break devonfw-ide. For the second point my thoughts are:
"master"
here is really a bug and does not make any sense. It has to be changed to branch
. I must have missed this in the review.ide-urls
we can actively pass "master"
as branch argument if we use the pullOrCloneAndResetIfNeeded
after all.null
was given for branch
what typically only should happen from delegation of methods with the same name but lacking the branch
parameter).For the ide-urls repo and the main
vs. master
branch, we should create a separate issue.
What we could do is copy (instead of rename) the master
branch to main
.
We could also test locally somehow with devonfw-ide if nothing breaks if the default branch gets changed (e.g. by changing the hardcoded URL to some fork where we test this in advance). Test must cover both initial setup as well as updates (devon ide update
).
ide-urls
https://github.com/devonfw/ide-urls/branches frommaster
tomain