devonfw / IDEasy

Tool to automate the setup and updates of a development environment for any project (Successor of devonfw-ide).
Apache License 2.0
8 stars 20 forks source link

Nightly build successful even if previous action failed because of the verify_commit job #426

Closed mvomiero closed 3 months ago

mvomiero commented 3 months ago

Expected behavior

Nightly build should fail if the last workflow that executed all the jobs (not only verify_commit) failed.

Actual behavior

If there is no commit in the last 24 hours, the workflow will just execute the verify_commit job and will succeed even if the last workflow run was failing.

Related/Dependent Issues

361

406

hohwille commented 3 months ago

My suggestion is to finally go to the proposed KISS approach and just always do the build every night to make it work. When this is live, we can again start work on a more sustainable build workflow and once it is completed and carefully tested, we can go back to a smarter approach.