Closed slskiba closed 13 hours ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
com/devonfw/tools/ide/tool/docker/Docker.java | 1 | 4.76% | ||
com/devonfw/tools/ide/tool/gh/Gh.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/aws/Aws.java | 2 | 5.71% | ||
com/devonfw/tools/ide/commandlet/HelpCommandlet.java | 2 | 93.37% | ||
com/devonfw/tools/ide/tool/ToolCommandlet.java | 5 | 69.93% | ||
<!-- | Total: | 11 | --> |
Totals | |
---|---|
Change from base Build 9708861274: | -0.05% |
Covered Lines: | 4994 |
Relevant Lines: | 7974 |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
com/devonfw/tools/ide/tool/docker/Docker.java | 1 | 4.76% | ||
com/devonfw/tools/ide/tool/gh/Gh.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/aws/Aws.java | 2 | 5.71% | ||
com/devonfw/tools/ide/commandlet/HelpCommandlet.java | 2 | 93.37% | ||
com/devonfw/tools/ide/tool/ToolCommandlet.java | 3 | 70.92% | ||
<!-- | Total: | 9 | --> |
Totals | |
---|---|
Change from base Build 9708861274: | -0.03% |
Covered Lines: | 4994 |
Relevant Lines: | 7972 |
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
com/devonfw/tools/ide/tool/terraform/Terraform.java | 1 | 33.33% | ||
com/devonfw/tools/ide/tool/helm/Helm.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/docker/Docker.java | 1 | 4.76% | ||
com/devonfw/tools/ide/tool/gradle/Gradle.java | 1 | 40.0% | ||
com/devonfw/tools/ide/tool/gh/Gh.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/dotnet/DotNet.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/kotlinc/Kotlinc.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/oc/Oc.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/npm/Npm.java | 1 | 95.65% | ||
com/devonfw/tools/ide/tool/quarkus/Quarkus.java | 1 | 66.67% | ||
<!-- | Total: | 23 | --> |
Totals | |
---|---|
Change from base Build 9708861274: | -0.02% |
Covered Lines: | 4996 |
Relevant Lines: | 7981 |
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
com/devonfw/tools/ide/tool/terraform/Terraform.java | 1 | 33.33% | ||
com/devonfw/tools/ide/tool/helm/Helm.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/docker/Docker.java | 1 | 4.76% | ||
com/devonfw/tools/ide/tool/gradle/Gradle.java | 1 | 40.0% | ||
com/devonfw/tools/ide/tool/gh/Gh.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/dotnet/DotNet.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/kotlinc/Kotlinc.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/oc/Oc.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/npm/Npm.java | 1 | 95.65% | ||
com/devonfw/tools/ide/tool/quarkus/Quarkus.java | 1 | 66.67% | ||
<!-- | Total: | 56 | --> |
Totals | |
---|---|
Change from base Build 9708861274: | 0.3% |
Covered Lines: | 5147 |
Relevant Lines: | 8177 |
If possible, please add a simple test to increase the test coverage here too. Just a check for a tool starting its simulated help command if it was found should suffice I guess.
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
com/devonfw/tools/ide/tool/terraform/Terraform.java | 1 | 33.33% | ||
com/devonfw/tools/ide/tool/helm/Helm.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/docker/Docker.java | 1 | 4.76% | ||
com/devonfw/tools/ide/tool/gradle/Gradle.java | 1 | 80.0% | ||
com/devonfw/tools/ide/tool/gh/Gh.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/dotnet/DotNet.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/kotlinc/Kotlinc.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/oc/Oc.java | 1 | 66.67% | ||
com/devonfw/tools/ide/tool/npm/Npm.java | 1 | 95.65% | ||
com/devonfw/tools/ide/tool/quarkus/Quarkus.java | 1 | 66.67% | ||
<!-- | Total: | 68 | --> |
Totals | |
---|---|
Change from base Build 9808498015: | -0.04% |
Covered Lines: | 5276 |
Relevant Lines: | 8226 |
Resolves #396.
While initially #396 sounded like a great idea, it might be troublesome in practice. Taking for example aws,
aws help
prints an incredibly long list of services (380+) to use with the aws cli, cluttering the output immensly.I therefore suggest the following solution to this issue:
printToolHelp
inToolCommandlet
runs the tool with the provided help command as input. The help command is by default set to null inToolCommandlet
, so if a tool does not specify otherwise, no tool-specific help is provided.<tool> help
output can overrideToolCommandlet
'sprintToolHelp
(e.g. AWS CLI, instead of printing 400+ lines of usage help, we can advise the user to useaws help
for detailed usage help)Example output for
ide help aws
:Example output for
ide help gh
: