search

devonfw / ide

Tool to automate setup and update of development environment (esp. for Java projects).
Apache License 2.0
35 stars 101 forks source link

Cleanup docker commandlet #1239

Closed hohwille closed 1 year ago

hohwille commented 1 year ago

I already marked this code with a TODO as it does not make any sense: https://github.com/devonfw/ide/blob/c97d701dd26760229db0b6c96b7ac6981bb4c13d/scripts/src/main/resources/scripts/command/docker#L60

Also I would question if we need this function at all: https://github.com/devonfw/ide/blob/c97d701dd26760229db0b6c96b7ac6981bb4c13d/scripts/src/main/resources/scripts/command/docker#L114

Is there actually a command rancher-desktop after all? https://github.com/devonfw/ide/blob/c97d701dd26760229db0b6c96b7ac6981bb4c13d/scripts/src/main/resources/scripts/command/docker#L130 IMHO it is the installer program and after installation that might be deleted so it is not a valid way to check it. Maybe we can strip out the entire function. However, maybe @cinnamon-coder-hub may still have some brain dump left and can explain why we may still need it.

hohwille commented 1 year ago

Was already fixed in 2023.07.003 - I linked the issues, assigned milestone and now close this ticket.