initial setup fails because urls is not cloned

[hohwille]

Expected behavior

As a devonfw-ide user, I want to setup my IDE automatically by just providing my settings URL so that I safe time and can directly jump start into my project.

Actual behavior

$ devon ide create fpse
You are not inside a devonfw-ide installation: /d/projects

*** Software Update of devonfw-ide-scripts ***
Updating fpse/ from https://repo.maven.apache.org/maven2/com/devonfw/tools/ide/devonfw-ide-scripts
Trying to determine the latest available version from https://repo.maven.apache.org/maven2/com/devonfw/tools/ide/devonfw-ide-scripts/maven-metadata.xml
Success: run command mkdir
Starting installation of devonfw-ide-scripts in version 2023.07.002 to fpse/
Trying to download devonfw-ide-scripts-2023.07.002.tar.gz from https://repo.maven.apache.org/maven2/com/devonfw/tools/ide/devonfw-ide-scripts/2023.07.002/devonfw-ide-scripts-2023.07.002.tar.gz
Artifact already exists at /c/Users/hohwille/Downloads/devonfw-ide/devonfw-ide-scripts-2023.07.002.tar.gz
To force update please delete the file and run again.
Success: run command tar
Successfully extracted archive devonfw-ide-scripts-2023.07.002.tar.gz to /d/projects/salog-demo/updates/extracted
Creating backup by moving existing fpse/ to /d/projects/salog-demo/updates/backups/23-07-25/19-05-02
Success: run command mv
Successfully installed devonfw-ide-scripts
Setting up your devonfw-ide in /d/projects/fpse
Creating main workspace directory
Installing devon autocompletion
Missing your settings at /d/projects/fpse/settings and no SETTINGS_URL is defined.
Further details can be found here:
https://github.com/devonfw/ide/blob/master/documentation/settings.asciidoc
Please contact the technical lead of your project to get the SETTINGS_URL for your project.
In case you just want to test devonfw-ide you may simply hit return to install default settings.

Settings URL [https://github.com/devonfw/ide-settings.git]: https://some.hostname.com/gitlab/some-user/fpse-settings.git
Cloning git repositroy from https://some.hostname.com/gitlab/some-user/fpse-settings.git
Cloning into '.'...

Unhandled Exception: System.ComponentModel.Win32Exception: Invalid window handle
   at MS.Win32.ManagedWndProcTracker.HookUpDefWindowProc(IntPtr hwnd)
   at MS.Win32.ManagedWndProcTracker.OnAppDomainProcessExit()
   at MS.Internal.ShutDownListener.HandleShutDown(Object sender, EventArgs e)
remote: Enumerating objects: 157, done.
remote: Counting objects: 100% (17/17), done.
remote: Compressing objects: 100% (16/16), done.
remote: Total 157 (delta 5), reused 6 (delta 1), pack-reused 140Receiving objects:  71% (112/157)
Receiving objects: 100% (157/157), 65.47 KiB | 2.04 MiB/s, done.
Resolving deltas: 100% (20/20), done.
Success: run command git
Copying template /d/projects/fpse/settings/devon/conf/devon.properties to /d/projects/fpse/conf/devon.properties.
Copying template /d/projects/fpse/settings/devon/conf/npm/.npmrc to /d/projects/fpse/conf/npm/.npmrc.

*** Setting up mvn ***
Success: run command mkdir
Starting installation of java in version 11.0.18_10 to /d/projects/fpse/software/java

******** ATTENTION ********
No url is configured at /d/projects/fpse/urls/java/java/11.0.18_10
We are sorry for the inconvenience. Please check the above errors, resolve them and try again.
Command 'java setup silent' failed with exit code 255

******** ATTENTION ********
Failed to run devon java setup silent
We are sorry for the inconvenience. Please check the above errors, resolve them and try again.
Exit code was 255
Command 'mvn setup' failed with exit code 255

******** ATTENTION ********
Failed to run devon mvn setup
We are sorry for the inconvenience. Please check the above errors, resolve them and try again.
Exit code was 255

Completed fpse

Steps to reproduce (bug) / Use Case of feature request (enhancement)

1. setup new devonfw ide from scratch or use devon ide create «project-name»
2. use a specific settings GIT URL (what I figured out is that you need to have all versions of DEVON_IDE_TOOLS defined to exact versions without using a * or leaving them undefined).
3. you will get such a confusing error

Related/Dependent Issues

Comments/Hints:

The problem is located here: https://github.com/devonfw/ide/blob/ecca89e8269660c99fa4ddc24a94ec58e8e568e5/scripts/src/main/resources/scripts/functions#L1304-L1322

As you can see doUpdateUrls (that clones ide-urls into the urls folder) is only called inside the if conditions but both are not met in this case.

Affected version:

• IDE 2023.07.001 and 2023.07.002