search

devonfw / ide

Tool to automate setup and update of development environment (esp. for Java projects).
Apache License 2.0
33 stars 102 forks source link

#1197 Integrated JavaMissionControl #1291

Closed moritzLanger closed 11 months ago

moritzLanger commented 11 months ago

1197 Integrate JavaMissionControl

Added the JmcUrlUpdater to UpdateManger function.

Added the jmc script.

Testing on a "real" Linux Computer still needs to be Done.

moritzLanger commented 11 months ago

Thank you for your PR. Can you please still go through the DoD and add the missing files like the documentation of the tool or LICENCE if needed.

Thanks for the reminder, I added the missing documentation.

hohwille commented 11 months ago

I wrote into the issue instead of the PR:

There is no jmc here: https://github.com/devonfw/ide-urls/tree/master/ We can not merge this without the download metadata being present. https://github.com/devonfw/ide/pull/1251/files only added the JmcUrlUpdater without adding it so it also gets executed.

OK. So the change to add the updater is included in this PR. I now remember that you already told this in advance. The problem with this approach is that we cannot properly test this before merging. However, I already approved and will merge then but I tend to first release our bugfix version 2023.08.001 and then merge this PR so we have some time left to test it before the next release will be made. Thanks again for your work. It all seems fine and I am quite confident that it will work 👍

hohwille commented 11 months ago

@moritzLanger I wanted to merge this now but unfortunately we have this meanwhile:

Conflicting files url-updater/src/main/java/com/devonfw/tools/ide/url/updater/UpdateManager.java

Can you merge & resolve this?

hohwille commented 11 months ago

Replaced by PR #1313, hence closing.