devonfw / ide

Tool to automate setup and update of development environment (esp. for Java projects).
Apache License 2.0
33 stars 102 forks source link

shellcheck fails in linux integration test #1301

Closed hohwille closed 11 months ago

hohwille commented 11 months ago
Running test #4: test-shellcheck

In scripts/functions line 1433:
      doDebug "Searching for Conntents folder in ${target_path}"
      ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In scripts/functions line 1434:
      pushd "${target_path}" > /dev/null || exit 255
      ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                                            ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In scripts/functions line 1437:
      contents="$(doGetFirstExistingPath *.app/Contents)"
      ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

In scripts/functions line 1438:
      popd > /dev/null || exit 255 
      ^---------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
                          ^-------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).

For more information:
  https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable...
[ERROR] Failed running test #4: test-shellcheck - exit code 1

This is not happening on other operating systems and did also not occur in the past for the linux integration test. IMHO it is most likely that on linux image a newer version of shellcheck has arrived that now reveals issues that have not been found in previous versions of shellcheck. We have to address this issue to make the integration test green again and also consider to upgrade our shellcheck on other platforms to ensure we get the same results on every OS.

hohwille commented 11 months ago

Did somebody change anything? Currently all Integration-Tests are green again. It's magic... I guess we can close this issue but if someone has some insights why the error went way, this would be beneficial.