devonfw / ide

Tool to automate setup and update of development environment (esp. for Java projects).
Apache License 2.0
33 stars 101 forks source link

maven installation location misconfigured (at least in eclipse) #1302

Closed hohwille closed 1 year ago

hohwille commented 1 year ago

Expected behavior

As a devonfw-ide user, I want a consistent project setup so that all works (including maven in Eclipse or Intellij)

Actual behavior

After default setup, my Eclipse configuration is broken as the maven installation points to a non-existing directory.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

  1. create new devonfw-ide
  2. devon eclipse
  3. Go to Preferences > Maven > Installations

Related/Dependent Issues

Comments/Hints:

https://github.com/devonfw/ide-settings/blob/7710bfef774c548199bcfca3b6f010427c77bed6/eclipse/workspace/update/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.m2e.core.prefs#L10

IMHO we cannot easily repair what has already happened out there in the wild. We could change ${DEVON_IDE_HOME}/software/maven to ${MAVEN_HOME} instead of ${DEVON_IDE_HOME}/software/mvn but all forks of our settings would need to upstream merge this change or they are broken.

Should we add a temporary workaround to create a symlink maven pointing to mvn in a migration script or is there any other/better solution? Or is it even better that all projects need to get aware of the problem and "repair" their settings?

Affected version:

jan-vcapgemini commented 1 year ago

Can be easily fixed in Eclipse. I've added a PR to ide-settings which should fix this issue for new installations too.

maven_missing_eclipse maven_missing_eclipse_fix01 maven_missing_eclipse_fix02