search

devonfw / ide

Tool to automate setup and update of development environment (esp. for Java projects).
Apache License 2.0
33 stars 102 forks source link

Wrong line endings in urls #1332

Open CREITZ25 opened 10 months ago

CREITZ25 commented 10 months ago

Expected behavior

As a developer, I always want to have the same conditions for implementing new features so that so that I don't have to analyze errors that have already been analyzed several times.

Actual behavior

A new feature reads a line from a file and reacts differently due to different newline characters

Steps to reproduce (bug) / Use Case of feature request (enhancement)

Actually this happens with pip commandlet:

cd to the urls directory and start the following find command: $ find . -type f | xargs file | grep "with no line terminators" ./git/git/security: ASCII text, with no line terminators ./pip/pip/latest/urls: ASCII text, with no line terminators

Comments/Hints:

We have to correct this files and add the correct line endings We should implement a test worflow such as "Update CITest.yml" in repository ide-mirrors.

Affected version:

hohwille commented 10 months ago

@CREITZ25 thanks for figuring this out and reporting this issue. Still I am a little confused from your description.

A new feature reads a line from a file and reacts differently due to different newline characters

What does really go wrong here or is the actual bug? Also later you show that trailing newlines are missing. However, different newline characters would IMHO indicate a CRLF vs. LF issue.

We should implement a test worflow such as "Update CITest.yml" in repository ide-mirrors.

Aren't we talking about ide-urls rather than ide-mirrors? And in case we take some action wouldn't it be smarter to update the update-urls.yml workflow to simply add any missing trailing newline?

CREITZ25 commented 10 months ago

@CREITZ25 thanks for figuring this out and reporting this issue. Still I am a little confused from your description.

A new feature reads a line from a file and reacts differently due to different newline characters

What does really go wrong here or is the actual bug? Also later you show that trailing newlines are missing. However, different newline characters would IMHO indicate a CRLF vs. LF issue.

We should implement a test worflow such as "Update CITest.yml" in repository ide-mirrors.

Aren't we talking about ide-urls rather than ide-mirrors? And in case we take some action wouldn't it be smarter to update the update-urls.yml workflow to simply add any missing trailing newline?

@hohwille The problem also occurred with ide-mirrors. In addition to LF and CRLF, there is also the option of not making a line break. I added that to the CITest.yml file. And we should also create such a test in ide-urls, which tests all 3 cases. That is what I meant and of course in ide-urls repository

hohwille commented 10 months ago

I added the missing newlines but I still have no idea what failed because of a missing newline in pip/pip/latest/urls? IMHO nothing was broken or got fixed by this change.