UrlUpdater changes both error and success timestamp

[hohwille]

Expected behavior

The UrlUpdater (update-urls.yml) should update status.json in the following ways:

• If a download verification failed and resulted in an error, then this should be set in the according error section (current error HTTP status code and timestamp of now) if the previous error timestamp is older than the success timestamp.
• If a download verification succeeded and its previous success timestamp is older than its error timestamp (download error went away), then the success timestamp should be updated to now.

Actual behavior

There is total non-sense happening. See e.g. this commit where both success and error timestamps have been set to the exact same instant of time. At one moment of time the state can either be error or success but not both. The fun fact and the actual reason seems to lay in the error status code that is set to 200:

"urls" : {
    "202695819" : {
      "success" : {
        "timestamp" : "2023-08-30T03:35:35.531458481Z"
        "timestamp" : "2023-08-31T03:41:43.706649707Z"
      },
      "error" : {
        "timestamp" : "2023-08-30T03:35:35.651600276Z",
        "timestamp" : "2023-08-31T03:41:43.840025356Z",
        "code" : 200
      }
    },

Steps to reproduce (bug) / Use Case of feature request (enhancement)

1. check this status.json: https://github.com/devonfw/ide-urls/blob/055a0285b38376ea49f612ac4e60eeb75c74e817/pip/pip/3.2/status.json#L10

Related/Dependent Issues

Comments/Hints:

Maybe we broke that code that determines if something is success or error from the response.

Affected version:

• current UrlUpdater code