search

dgquvn / repo

1 stars 1 forks source link

Where's the test you wanted me to look at? #9

Closed jayjaybillings closed 7 years ago

jayjaybillings commented 7 years ago

@dgquvn Where's the test you wanted me to look at? I checked out the code this morning and built the version in the FizzBuzz repo, but couldn't find a tests/ directory. Just let me know and I'll give it a look.

dgquvn commented 7 years ago

Hello Jay,

tests/directory is within the FizzBuzz_classes. The test “test_inputProperties.cpp” has two tests, where the commented first test is the one which I want you to find out why it failed to test.

Best regards, Blueze

On Aug 28, 2017, at 8:02 AM, Jay Jay Billings notifications@github.com wrote:

@dgquvn https://github.com/dgquvn Where's the test you wanted me to look at? I checked out the code this morning and built the version in the FizzBuzz repo, but couldn't find a tests/ directory. Just let me know and I'll give it a look.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dgquvn/repo/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AbQTTPy3WSfvZt6k8Dsl5V5oNSbBTXUTks5scqxHgaJpZM4PEbaI.

jayjaybillings commented 7 years ago

Are you sure that you committed and pushed it? I don't see it in the repo.

dgquvn commented 7 years ago

Yes, I did. It is in the directory below

repo/FizzBuzz_generic_v2/FizzBuzz_classes/tests/test_inputProperties.cpp

jayjaybillings commented 7 years ago

I see it in the master branch but not the FizzBuzz branch. I'll look into it.

jayjaybillings commented 7 years ago

I fixed the test in PR #11 and commit a14bec0.

The problem that I encountered when I tried to compile was that BOOST_CHECK_EQUAL cannot directly compare two maps. The solution that I provided in my PR is one good, succinct way to check the maps.

jayjaybillings commented 7 years ago

Since you accepted the pull request, I'm going to close this.