dheera / rosboard

ROS node that turns your robot into a web server to visualize ROS topics
Other
823 stars 161 forks source link

Fix rosboard not starting on ROS1 systems since it doesn't know QoSProfile #116

Closed MCFurry closed 9 months ago

MCFurry commented 9 months ago

Since PR https://github.com/dheera/rosboard/pull/104 got merged, rosboard doesn't start anymore. This is because on initializing the node, it can't define the get_topic_qos() function since it doesn't know its output.

The proposed fix therefore only defines this function IF we are in a ros2 environment.

(My editor also auto removes trailing whitespaces, sorry for the remaing diff...)

dheera commented 9 months ago

Thanks!