search

dheera / rosboard

ROS node that turns your robot into a web server to visualize ROS topics
Other
823 stars 161 forks source link

Add ros2 QoS BestEffort and Volatile by default #94

Closed charlielito closed 2 years ago

dheera commented 2 years ago

Hi @charlielito interesting thought, any reason why you deleted this PR?

charlielito commented 2 years ago

Oh because this would be hardcoded for every topic and cannot be customized per topic as per #93 . Nonetheless, BestEffort and Volatile are compatible with most of QoS people normally use, but default is not compatible with sensor QoS for topics like images, scan, pointclouds. So it might be better to have this while #93 is addressed. If you agree I can re open it

Hi @charlielito interesting thought, any reason why you deleted this PR?