search

dhruvagarwal / geekometer

This chrome extension keeps a track of the problems solved by you on geeksforgeeks.org, and crosses them out.Hence, easing it out for you to concentrate on missed ones
Apache License 2.0
36 stars 16 forks source link

Fix to previous PR #12

Closed raj454raj closed 8 years ago

raj454raj commented 8 years ago

Turns out that previous one worked for some of the pages. Check if this is not working for anything. I have tried many possibilities. Sorry!

dhruvagarwal commented 8 years ago

Nope. This doesn't work as well. Wait I'll have to do a fix for it. If you're trying a few things please test on most of the pages.

On Tue 8 Dec, 2015 23:37 Raj notifications@github.com wrote:

Turns out that previous one worked for some of the pages. Check if this is

not working for anything. I have tried many possibilities. Sorry!

You can view, comment on, or merge this pull request online at:

https://github.com/dhruvagarwal/geekometer/pull/12 Commit Summary

  • Fix to previous PR

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/dhruvagarwal/geekometer/pull/12.

raj454raj commented 8 years ago

For which URL is it not working?

dhruvagarwal commented 8 years ago

geeksforgeeks.org

raj454raj commented 8 years ago

screenshot from 2015-12-08 23 57 18 screenshot from 2015-12-08 23 56 47 screenshot from 2015-12-08 23 56 25

See in the console. I am successfully overriding the gfg site css. Give me a screenshot of the console. Check if that css file is actually loaded or not.

raj454raj commented 8 years ago

You will obviously need to disable the actual one and load only this extension from filesystem.

dhruvagarwal commented 8 years ago

Obviously ! but screenshot from 2015-12-09 00 01 55

raj454raj commented 8 years ago

Give me the screenshot of "inspect element" of that input checkbox

dhruvagarwal commented 8 years ago

@raj454raj You're right ! my chrome was caching .. though i was hard refreshing but still couldnt get it right. Tried it in incognito and that worked.

Thanks !

raj454raj commented 8 years ago

I think the previous PR was also correct ! :smile: :D PS: But this one makes more sense.