search

diasurgical / psx-tools

Tools for the Playstation port of Diablo.
21 stars 2 forks source link

POSIX and 64bit compatibility #1

Closed john-tornblom closed 4 years ago

john-tornblom commented 4 years ago

These changes makes the source compile and run correctly on 64bit Linux-based OSes

john-tornblom commented 4 years ago

Also, see https://github.com/john-tornblom/psx-tools/tree/audio-lang where I've used your tools to change the audio of the MPQ PC-version to include other languages

AJenbo commented 4 years ago

Nice work, but i would suggest creating a patch_rt.mpq instead of editing diabdat.mpq. Some mods and tools will check the md5 of diabdat.mpq. patch_rt.mpq is pretty small and only ever contained some updated menu graphics for bnet. Mods like DevilutionX will be looking for something like jp.mpq and fr.mpq for just the language specific content, depending on what language the user selects.

john-tornblom commented 4 years ago

Ah, I did not know that, thanks.

ghost commented 4 years ago

Adds compatibility for linux, breaks compatibility on windows.

AJenbo commented 4 years ago

Time to setup a CI build?

john-tornblom commented 4 years ago

Adds compatibility for linux, breaks compatibility on windows.

I apologize, I have not used windows for a very long time, so I forget what discrepancies there are between our environments. CI would have helped me in this situation, but it might be a bit overkill just to check my PRs.

ghost commented 4 years ago

Some genius who invented the 64-bit compiler decided to make int use 64-bits, despite the fact we have things like longlong specifically for that. So it's not really your fault.

ghost commented 4 years ago

Time to setup a CI build?

This entire project/organization is now yours. Do whatever you want.