search

dib-lab / dib_rotation

Metagenomics DIB-lab rotation project
https://dib-lab.github.io/dib_rotation/
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

conda environment name typo #25

Closed clmattson-zz closed 3 years ago

clmattson-zz commented 3 years ago

This might be splitting hairs, but in file 02_conda, we create a rotation environment called "dib_rotation" but later in 05_starting_with_data, try to activate an environment called "2020_rotation" which I believe doesn't work because we haven't created it. Simple, but may confuse an inexperienced user.

taylorreiter commented 3 years ago

This is not splitting hairs and is very important, great catch! Would you like to try and put in a pull request that fixes this?

clmattson-zz commented 3 years ago

Taylor,

Hmmmm sure! How do I do that? 🙂 I have used github before, but only for my own projects, if that makes sense? So I don't think I've ever made a pull request.

Courtney

-- Courtney Mattson Ph.D. Student Microbiology Graduate Group University of California, Davis (410)-610-9282

From: Taylor Reiter notifications@github.com Sent: Sunday, November 15, 2020 3:54 PM To: dib-lab/dib_rotation dib_rotation@noreply.github.com Cc: Courtney Mattson clmattson@ucdavis.edu; Author author@noreply.github.com Subject: Re: [dib-lab/dib_rotation] conda environment name typo (#25)

This is not splitting hairs and is very important, great catch! Would you like to try and put in a pull request that fixes this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dib-lab/dib_rotation/issues/25#issuecomment-727635137, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARYPJMSDMPBAYIBACZH6YETSQA5YVANCNFSM4TWNLKPQ.

taylorreiter commented 3 years ago

closed by #30