dib-lab / dib_rotation

Metagenomics DIB-lab rotation project
https://dib-lab.github.io/dib_rotation/
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

[MRG] a 2022 update - fix many misc things! #47

Closed ctb closed 2 years ago

ctb commented 2 years ago

Fix many issues. Also -

Fixes https://github.com/dib-lab/dib_rotation/issues/34 Fixes https://github.com/dib-lab/dib_rotation/issues/41 Fixes https://github.com/dib-lab/dib_rotation/issues/42 Fixes https://github.com/dib-lab/dib_rotation/issues/43 Fixes https://github.com/dib-lab/dib_rotation/issues/44 Fixes https://github.com/dib-lab/dib_rotation/issues/45 by installing mamba up front Fixes https://github.com/dib-lab/dib_rotation/issues/46

Note that early attempts to pin the dib_rotation conda environment to python=3.8 ran afoul of this problem where conda installs a very old version of mamba when python=3.8! So I ended up installing mamba in base.

cc @ccbaumler

ctb commented 2 years ago

we need to manually update the mkdocs site, right @bluegenes ?

bluegenes commented 2 years ago

we need to manually update the mkdocs site, right @bluegenes ?

No, I think the GitHub actions should automatically deploy the site, as long as the markdown syntax is good!

If you're adding pages, then yes, we need to manually add those refs to mkdocs.yml

ctb commented 2 years ago

If you're adding pages, then yes, we need to manually add those refs to mkdocs.yml

no added pages!

ctb commented 2 years ago

@ccbaumler have you taken a look at these changes? any comments or concerns?

ccbaumler commented 2 years ago

Hi @ctb,

I am not noticing anything glaring but if you would like I can work through the entire website again this week to find any remaining typos or possible areas of improvement.

Respectfully, Colton