Open MichaelRoeder opened 8 years ago
Do i understood it correct? The sameAs retrieves entities which are the same as the resource. And for these entities it will be checked if they exists. So the sameAs retrieval should immediately check if the entity exists instead of doing this after the sameAs retrieval.
So instead of the AbstractDataset the SameAsRetriever should "start" the EntityChecker and the problem should be solved... or did i miss something?
It is a little bit more complicated (otherwise it would be too easy :wink: )
If a dataset is loaded it is preprocessed by
However, the first step already checks whether an entity exists since it can not retrieve information about an entity if it is not existing. Thus, I would like to combine both functionalities into one single preprocessing.
There are some additional requirements that have to be taken into account.
DomainBasedSameAsRetrieverManager
, EntityCheckerManager
) that choose SameAsRetriever
or EntityChecker
instances for a given URI based on the domain/namespace of the URI.You might want to take a look into the sameas
and the check
packages as well as their JUnit tests to get a better understanding. After that you should think about the structure the preprocessing should have and how it can fulfill the requirements. We can discuss about that if you want.
Cheers, Micha
According to a comment in #137 this preprocessing should only be done, if it is needed for the experiment. But this can be added later on, after the refactoring described above is done.
At the moment, the sameAs retrieval as well as the entityChecking are done independently. However, if the sameAs retrieval was able to retrieve data for a given URI, the entity checking can be skipped. Thus, these two steps should be combined into one single step.