dieterich-lab / Baltica

Baltica: integrated differential junction usage
https://dieterich-lab.github.io/Baltica/
MIT License
8 stars 3 forks source link

Differences in annotate_SJ.R diposited in Baltica and scripts folder #19

Closed Antgomoplx closed 1 year ago

Antgomoplx commented 2 years ago

Hi,

I saw differences in Baltica's actual release regarding this script ( the one in Baltica's folder) compared to the one located in scripts folder. In the first one I see that the function filter_hits_by_diff is not used, so as far this is the main point of the results integration among all 4 methods (https://dieterich-lab.github.io/Baltica/integration.html#annotating-the-results) I want to know if this has changed by the use of the simple merge by coordinates in the script ( line 354)

Many thanks in advance!

tbrittoborges commented 2 years ago

Hi, Antgomoplx, you are correct. Currently, filter_hits_by_diff is not used as we recently preferred to keep the integration simple. I will correct the error in the documentation. Thank you for the feedback!

Just to detail:

(sorry about the delay, I am out of the office)

tbrittoborges commented 2 years ago

fixed in bad2483