search

dieterich-lab / scimodom

Sci- ModoM: A quantitative database of transcriptome-wide high-throughput RNA modification sites
https://dieterich-lab.github.io/scimodom/
GNU Affero General Public License v3.0
0 stars 0 forks source link

Compare view: wrong upload sequence #93

Closed eboileau closed 3 months ago

eboileau commented 4 months ago

A clear and concise description of what the bug is.

Minimal steps to reproduce the bug:

To test file size limit (client-side), e.g. reduce size here e.g. to 1024 https://github.com/dieterich-lab/scimodom/blob/67898cdb8c09520371fa95b1a7ed9267a1a33eae/client/src/components/compare/CompareStepB.vue#L22

then go to Compare view

A. Select a reference dataset B. Upload a file that satisfies the criteria e.g. < 1KB B. Change your mind and upload a new file that does NOT satisfy the criteria e.g. > 1KB

As expected, we get an upload error Invalid file size, file size should be smaller than 1 KB. However, we are still able to go to step

C. Select query criteria and submit.

The query uses the last successful upload (first file selected in B, as it still appears in the input form). The submit button should in fact be disabled if there is a failed upload (i.e. the input form should be cleared).

Output or error messages.

No response

Additional context

No response

What browser were you using?

Firefox, Chrome

What version of Sci-ModoM were you using?

dev

eboileau commented 4 months ago

The result is effectively the same if we change the file size limit on the server-side e.g. here https://github.com/dieterich-lab/scimodom/blob/67898cdb8c09520371fa95b1a7ed9267a1a33eae/server/src/scimodom/api/transfer.py#L10

We get the dialog box with Failed to upload - File to large (max. 1024) on the second attempt, but if we reproduce the sequence above, the last successful upload is used for comparison.