digiaonline / react-foundation

Foundation as React components.
https://digia.online/react-foundation-docs/
MIT License
601 stars 68 forks source link

Implement selfAlign{X|Y}, fix flexOrder{Small|Medium|Large} #102

Closed stefanhamburger closed 1 year ago

stefanhamburger commented 4 years ago

Currently, the flexbox props selfAlignX and selfAlignY are not implemented. This PR implements these props.

Note that in horizontal grids (.grid-y aka <Grid horizontal>) the X and Y axes are technically swapped but since this is not respected for the alignX and alignY props, I see no need to respect it for selfAlignX and selfAlignY.

In addition, this fixes a bug where the flexOrderSmall, flexOrderMedium and flexOrderLarge props would set the class name based on the flexOrder value.

Finally, this fixes the test (which previously did nothing) so it now actually tests the class names.

hugovk commented 1 year ago

Thanks for the PR, however we are going to archive this repo because we're no longer using or maintaining it.