digiaonline / react-foundation

Foundation as React components.
https://digia.online/react-foundation-docs/
MIT License
601 stars 68 forks source link

'isDisabled' property on buttons does not disable the button #104

Closed DanielReid closed 1 year ago

DanielReid commented 4 years ago

Hi, I'd expect the isDisabled property to also have semantic functionality like it does on the normal <button> html component instead of purely cosmetic styling as currently is the case.

What did you do?

What did you expect to happen?

I expected the button to not call its onClick method when clicked

What actually happened?

The method was called

What version of this module are you using?

^0.9.6

Please include code that reproduces the issue. The best reproductions are self-contained scripts with minimal dependencies.

<Button
          id="next-button"
          onClick={() => {console.log('hi!') }}
          isDisabled={true}
        >
          Next step
</Button>
hugovk commented 1 year ago

Thanks for the report, however we are going to archive this repo because we're no longer using or maintaining it.