The primary purpose of this PR is to add the pagination to the bottom of the issue details page
It also updates the error summary heading on the issue details page to indicate the correct count of issues (as datasette limits returned rows to 1000, this was previously incorrect)
for now this has made another issue apparent which is the error summary component only shows 1k errors, this should be resolved in the future when the design is amended by Alex
I used this page to test the pagination. going through many pages to make sure it works as expected.
also looking at the error summary header to make sure it gives the correct number of entities with issues ()
Added/updated tests?
I moved the pagination tests into their own file as well as added some specific tests checking the rendered pagination component on the issuedeetails template
What type of PR is this? (check all applicable)
Description
The primary purpose of this PR is to add the pagination to the bottom of the issue details page It also updates the error summary heading on the issue details page to indicate the correct count of issues (as datasette limits returned rows to 1000, this was previously incorrect)
for now this has made another issue apparent which is the error summary component only shows 1k errors, this should be resolved in the future when the design is amended by Alex
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
I used this page to test the pagination. going through many pages to make sure it works as expected.
also looking at the error summary header to make sure it gives the correct number of entities with issues ()
Added/updated tests?
I moved the pagination tests into their own file as well as added some specific tests checking the rendered pagination component on the issuedeetails template