Bug: Map on Check defaults to London

digital-land / submit

0 stars 1 forks source link

Bug: Map on Check defaults to London #449

Open MJFaucherFolie opened 2 months ago

MJFaucherFolie commented 2 months ago

Issue:

We've enabled maps to display when users are checking their data, but the map will default to London:

Who raised it

MJ & LPA via Jira

Problem causing

LPAs, such as New Forest NPA are unable to see their data visualised on a map prior to submission.

Tasks:

[ ] Investigate why this occurs
[ ] Agree the right approach

Example:

https://submit.planning.data.gov.uk/check/results/oXLy83RBDzUtMzUGmrfdy6/0

DilwoarH commented 3 weeks ago

@MJFaucherFolie - can you give the URL you used to create the example please?

MJFaucherFolie commented 3 weeks ago

@MJFaucherFolie - can you give the URL you used to create the example please?

Hey Dilwoar! Here is the link - https://submit.planning.data.gov.uk/check/results/oXLy83RBDzUtMzUGmrfdy6/0

DilwoarH commented 3 weeks ago

@MJFaucherFolie - can you give the URL you used to create the example please?

Hey Dilwoar! Here is the link - https://submit.planning.data.gov.uk/check/results/oXLy83RBDzUtMzUGmrfdy6/0

Sorry should have been clear - I meant the CSV/GeoJSON or URL for the source

neilfwar commented 2 weeks ago

@DilwoarH @MJ what was the outcome of the bug fix ? ie what was done?

DilwoarH commented 2 weeks ago

@DilwoarH @MJ what was the outcome of the bug fix ? ie what was done?

Hi @neilfwar - we pushed a fix that ensures the map is cantered to points correctly. However, we discovered that there were a few issues with the data validation:

Point data formatting isn't correctly validated
Geo X and Geo Y columns are not correctly validated

The issue raised is fixed but the above need to be resolved by infrastructure team.

GeorgeGoodall-GovUk commented 5 days ago

We are still seeing this happen. Here’s an example: https://submit.planning.data.gov.uk/check/results/S9KfzRorj6htq2CE4vr5FM/0 Source data: https://www.highpeak.gov.uk/media/4893/Brownfield-Land-Register-2023-CSV/Excel/5chp23.brownfield-land_register.csv?m=1703059825267

DilwoarH commented 19 hours ago

This was caused by invalid WKT data.

Invalid formats such as POINT ( -1.909243 53.264474) where it should be POINT (-1.909243 53.264474) could break the map.

A PR has been raised to ensure invalid points are not added to the map but should this be raised as an error by the request API?

cc @GeorgeGoodall-GovUk @MJFaucherFolie @alextea @CharliePatterson